Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling on discover page #24

Closed

Conversation

leodenham
Copy link

This pull request resolves issues with scrolling on the discover page.

Before:

  • Could not vertically scroll when hovering over movie card
  • Could not horizontal scroll without jumping and jank.

After:

  • Removed all scroll hijacking.

@sussy-code
Copy link
Collaborator

Hi thanks for your PR, this is a difficult issue for me. Please send a video of your new scrolling thingie.

@leodenham
Copy link
Author

leodenham commented May 11, 2024

Hi thanks for your PR, this is a difficult issue for me. Please send a video of your new scrolling thingie.

Heres a gif of it in operation (using a trackpad)
CleanShot 2024-05-11 at 16 06 02

@TecEash1
Copy link
Contributor

Ayy u managed to do it

@sussy-code
Copy link
Collaborator

Still cant scroll using mouse wheel, this is a must bc it is rlly cool!

@sussy-code
Copy link
Collaborator

Still unresolved.

@sussy-code sussy-code closed this May 15, 2024
@bobbytxt
Copy link
Contributor

bobbytxt commented May 29, 2024

Hey, I was looking at the code for this pull request and I had noticed that you can't scroll using mouse wheel simply because a piece of the code was removed that removed the handling of the wheel. onMouseEnter & onMouseLeave is also needed to handle the changing of overflow states.

onMouseEnter={handleMouseEnter}
onMouseLeave={handleMouseLeave}
onWheel={(e) => handleWheel(e, categorySlug)} 

Drag Racing

I'm not sure if this was intentional, but this is what fixed it.

@sussy-code
Copy link
Collaborator

huh ok i will reopen

@sussy-code sussy-code reopened this May 30, 2024
@sussy-code sussy-code closed this May 31, 2024
@bobbytxt bobbytxt mentioned this pull request Jun 4, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants